Skip to content

Release bash-language-server version 3 #388

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 13, 2022
Merged

Release bash-language-server version 3 #388

merged 3 commits into from
May 13, 2022

Conversation

skovhus
Copy link
Collaborator

@skovhus skovhus commented May 13, 2022

The one with shellcheck integration!

@skovhus skovhus mentioned this pull request May 13, 2022
@codecov
Copy link

codecov bot commented May 13, 2022

Codecov Report

Merging #388 (dd74507) into master (0f607ba) will decrease coverage by 1.04%.
The diff coverage is n/a.

❗ Current head dd74507 differs from pull request most recent head d44f91e. Consider uploading reports for the commit d44f91e to get more accurate results

@@            Coverage Diff             @@
##           master     #388      +/-   ##
==========================================
- Coverage   73.96%   72.91%   -1.05%     
==========================================
  Files          19       18       -1     
  Lines         653      576      -77     
  Branches      112       94      -18     
==========================================
- Hits          483      420      -63     
+ Misses        144      135       -9     
+ Partials       26       21       -5     
Impacted Files Coverage Δ
server/src/config.ts 100.00% <0.00%> (ø)
vscode-client/src/extension.ts 0.00% <0.00%> (ø)
server/src/linter.ts
server/src/server.ts 59.23% <0.00%> (+1.79%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e55bac8...d44f91e. Read the comment docs.

@shabbyrobe
Copy link
Contributor

Readme update looks good to me! Depending on the level of detail you want to go into, is it worth calling out SHELLCHECK_PATH can be used to override, but otherwise it will look for shellcheck on your $PATH?

@skovhus skovhus enabled auto-merge May 13, 2022 13:55
@skovhus skovhus merged commit 52ba5dc into master May 13, 2022
@skovhus skovhus deleted the ks/prepare-release branch May 13, 2022 13:56
@shabbyrobe
Copy link
Contributor

Released! Amazing! Thank you 😄

I'll be around a bit this weekend (Australian time), please don't hesitate to @ me if people are experiencing breakage and you want me to lend a hand.

@skovhus
Copy link
Collaborator Author

skovhus commented May 13, 2022

Awesome thanks! 🙏

Would you mind giving v 3 a spin locally once it’s out on npm (should be any minute now)?

@shabbyrobe
Copy link
Contributor

Seems to be working so far, I'll try to push it a bit harder now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants